Skip to content

Add Checker::ignore - #1393

Merged
clauderic merged 1 commit into
mainfrom
theme-check-ignore
Nov 12, 2026
Merged

clauderic merged 1 commit into
mainfrom
theme-check-ignore

Conversation

@clauderic

@clauderic clauderic commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

What are you adding in this PR?

Checker::ignore([...]), the files a run leaves out, as in .theme-check.yml's ignore. A pattern matches anywhere in the theme unless it starts with /, which is from the root.

agent-server checks Shell themes and needs to skip their _drafts folders: .ignore(["_drafts/**"]). Ignored files aren't read or checked, so lookups like block schemas don't find them either.

Stacked for agent-server, to merge in order:

  1. Add Checker::ignore #1393 Checker::ignore (this PR)
  2. Add Checker::threads #1394 Checker::threads
  3. Add Checker::cancelable #1395 Checker::cancelable

Tophatting

  • The doc test on Checker::ignore leaves out a block in _drafts.
  • cargo test --workspace

Before you deploy

  • I included a patch bump changeset. theme-check-rs is 0.1.x, where an addition is a patch bump (0.1.0 → 0.1.1).
  • My feature is backward compatible

🤖 Generated with Claude Code

@clauderic
clauderic requested a review from a team as a code owner November 12, 2026 17:54
This was referenced Nov 12, 2026
@clauderic
clauderic added this pull request to stack #1396 November 12, 2026 19:27
The files a run leaves out, as in `.theme-check.yml`'s `ignore`. agent-server
checks the whole theme except `_drafts` folders, which is `.ignore(["_drafts/**"])`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@clauderic
clauderic merged commit 1cee455 into main Nov 12, 2026
9 checks passed
@clauderic
clauderic deleted the theme-check-ignore branch November 12, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants